Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exit code to the compatibility tool. #45642

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

Sl4vP0weR
Copy link
Contributor

Microsoft.DotNet.ApiCompat.Tool always returns a 0 exit code, which means users are unable to determine if the compatibility check was successful or not without reading the output. Mainly contribute this change because I don't want to determine it based on the output via grep or other tool as a workaround.

@Sl4vP0weR Sl4vP0weR requested a review from a team as a code owner December 27, 2024 18:54
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-ApiCompat untriaged Request triage from a team member labels Dec 27, 2024
@Sl4vP0weR
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks for the fix.

@ViktorHofer ViktorHofer merged commit ce24ceb into dotnet:main Dec 30, 2024
34 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-ApiCompat untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants